Switch Default TAS Placement Algorithm from BestFit to Mixed. #7416

iomarsayed · 2025-10-28T08:44:56Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Switch Default TAS Placement Algorithm from BestFit to Mixed, by enabling TAS Mixed Profile.

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?

TAS: change the algorithm used in case of "unconstrained" mode (enabled by the kueue.x-k8s.io/podset-unconstrained-topology annotation, or when the "implicit" mode s used) from "BestFit" to "LeastFreeCapacity". 

This allows to optimize the fragmentation for workloads which don't require bin-packing.

netlify · 2025-10-28T08:45:02Z

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	`94a293e`
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6908c69a4bb4ec0008a84866

k8s-ci-robot · 2025-10-28T08:45:05Z

Hi @iomarsayed. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mimowo · 2025-10-28T09:11:03Z

/ok-to-test
Thanks 👍

mimowo · 2025-10-29T14:52:11Z

pkg/features/kube_features.go

 	TASProfileMixed: {
 		{Version: version.MustParse("0.10"), Default: false, PreRelease: featuregate.Alpha},
-		{Version: version.MustParse("0.11"), Default: false, PreRelease: featuregate.Deprecated},
+		{Version: version.MustParse("0.11"), Default: true, PreRelease: featuregate.Deprecated},


It should no longer be deprecated since enabled by default, I think it should be

a new entry rather than modifying old, so:

{Version: version.MustParse("0.10"), Default: false, PreRelease: featuregate.Alpha}, {Version: version.MustParse("0.11"), Default: false, PreRelease: featuregate.Deprecated}, {Version: version.MustParse("0.15"), Default: true, PreRelease: featuregate.Beta},

Please also adjust the KEP in the table https://github.com/kubernetes-sigs/kueue/pull/7144/files#diff-c8054619a353d0fc872425de6a22f0df62001353eb75f856d5ba504553b5fcbfR1075

cc @olekzabl

Seeing the failures I think we should still update the old one retrospectively from Deprecated to Alpha

Yea, ok so I did that too.

mimowo · 2025-10-29T14:58:29Z

/release-note-edit

TAS: change the algorithm used in case of "unconstrained" mode (enabled by the kueue.x-k8s.io/podset-unconstrained-topology annotation, or when the "implicit" mode s used) from "BestFit" to "LeastFreeCapacity". 

This allows to optimize the fragmentation for workloads which don't require bin-packing.

iomarsayed · 2025-11-03T13:11:47Z

/retest

kshalot · 2025-11-03T13:41:14Z

keps/2724-topology-aware-scheduling/README.md

 | feature gate / annotation                  | preferred         | required          | unconstrained     |
 | ------------------------------------------ | ----------------- | ----------------- | ----------------- |
-| None <br/> or TASProfileMixed (deprecated) | BestFit           | BestFit           | LeastFreeCapacity |
+| None <br/> or TASProfileMixed (default) | BestFit           | BestFit           | LeastFreeCapacity |


Yes agreed, done!

kshalot · 2025-11-03T13:56:07Z

pkg/features/kube_features.go

+		{Version: version.MustParse("0.11"), Default: false, PreRelease: featuregate.Alpha},
+		{Version: version.MustParse("0.15"), Default: true, PreRelease: featuregate.Beta},


Isn't line 273 obsolete now? From what I understand, you could drop it now:

Suggested change

{Version: version.MustParse("0.11"), Default: false, PreRelease: featuregate.Alpha},

{Version: version.MustParse("0.15"), Default: true, PreRelease: featuregate.Beta},

{Version: version.MustParse("0.15"), Default: true, PreRelease: featuregate.Beta},

@iomarsayed I think you deleted the wrong line in f9ea38f - removing the one with "0.10" would change the behavior, no?

Yes 0.10 shouldn't have been the one removed to ensure safety. thank you!

mimowo · 2025-11-04T08:50:05Z

Thank you 👍
/lgtm
/approve

k8s-ci-robot · 2025-11-04T08:50:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iomarsayed, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mimowo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-11-04T08:50:14Z

LGTM label has been added.

Git tree hash: 1212028ebbab688ef516ef69365680c45a96f2ac

…etes-sigs#7416) * Enable TAS Mixed Profile for default * adjust feature and kep * remove deprecation of current version for TASProfileMixed * cleanups * fix typo

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. labels Oct 28, 2025

k8s-ci-robot requested review from gabesaba and mimowo October 28, 2025 08:45

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 28, 2025

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 28, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 28, 2025

mimowo reviewed Oct 29, 2025

View reviewed changes

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 29, 2025

iomarsayed added 3 commits November 3, 2025 13:09

Enable TAS Mixed Profile for default

787d538

adjust feature and kep

09ac41a

remove deprecation of current version for TASProfileMixed

07bbf53

kshalot reviewed Nov 3, 2025

View reviewed changes

cleanups

f9ea38f

iomarsayed force-pushed the 7214-switch-default-placement-algorithm-to-mixed branch from ede4856 to f9ea38f Compare November 3, 2025 14:36

fix typo

94a293e

k8s-ci-robot assigned mimowo Nov 4, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2025

k8s-ci-robot merged commit 7a8b75b into kubernetes-sigs:main Nov 4, 2025
23 checks passed

k8s-ci-robot added this to the v0.15 milestone Nov 4, 2025

	\| None <br/> or TASProfileMixed (default) \| BestFit \| BestFit \| LeastFreeCapacity \|
	\| None <br/> or TASProfileMixed (default) \| BestFit \| BestFit \| LeastFreeCapacity \|

		{Version: version.MustParse("0.11"), Default: false, PreRelease: featuregate.Alpha},
		{Version: version.MustParse("0.15"), Default: true, PreRelease: featuregate.Beta},

Switch Default TAS Placement Algorithm from BestFit to Mixed. #7416

Switch Default TAS Placement Algorithm from BestFit to Mixed. #7416

Uh oh!

Conversation

iomarsayed commented Oct 28, 2025 • edited by k8s-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?

Uh oh!

netlify bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Uh oh!

k8s-ci-robot commented Oct 28, 2025

Uh oh!

mimowo commented Oct 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mimowo commented Oct 29, 2025

Uh oh!

iomarsayed commented Nov 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kshalot Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mimowo commented Nov 4, 2025

Uh oh!

k8s-ci-robot commented Nov 4, 2025

Uh oh!

k8s-ci-robot commented Nov 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

iomarsayed commented Oct 28, 2025 •

edited by k8s-ci-robot

Loading

netlify bot commented Oct 28, 2025 •

edited

Loading

kshalot Nov 3, 2025 •

edited

Loading